Review /germplasm endpoint / records content

terraref / brapi

Breeder's API implementation for TERRA-REF

https://terraref.org/brapi/v1/calls

BSD 3-Clause "New" or "Revised" License

0 stars 2 forks source link

Review /germplasm endpoint / records content #25

Open dlebauer opened 5 years ago

dlebauer commented 5 years ago

are you able to access and understand our germplasm responses?
is the information accurate and useful (i.e. can you check out the cross refs and additional meta-data that we looked up? e.g. the taxon ids and references to genysis?
Is there enough metadata or additional metadata that we should provide?
any other suggestions and feedback welcome!

https://terraref.org/brapi/v1/germplasm https://terraref.org/brapi/v1/studies/6000000034/germplasm

@ajo2995

ajo2995 commented 5 years ago

I'll be glad to review the responses with some others from the lab next week. One minor technical thing, the /studies call pagination metadata has a totalCount that is off by one.

robkooper commented 5 years ago

@ajo2995 I think i fixed this already, there was a an issue with unique names that should be fixed now. Let me know if it is still broken.

dlebauer commented 5 years ago

@robkooper this endpoint says 326 records in the metadata but only returns 325 records https://brapi-dev.workbench.terraref.org/brapi/v1/studies/6000000034/germplasm

robkooper commented 5 years ago

@dlebauer were missing entry germplasm with id=6000001456

Fixed code to print warning to log and deduct missing germplasm from return count.

dlebauer commented 3 years ago

@ajo2995 just a reminder - please let me know if you have any feedback on the germplasm metadata contained in these endpoints