search

terraref / brapi

Breeder's API implementation for TERRA-REF
https://terraref.org/brapi/v1/calls
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Issue 583/clean up yaml #32

Closed tcnichol closed 5 years ago

tcnichol commented 5 years ago

Unused paths should be removed from the yaml file. A brapi_complete.yaml contains all paths.

max-zilla commented 5 years ago

Changes seem OK at a glance but the diff is massive, have you deployed this to see what the swagger doc looks like?

tcnichol commented 5 years ago

I will check using swagger locally and compare.

tcnichol commented 5 years ago

I checked locally against brapi-dev by running swagger locally. This should be fixed now.

max-zilla commented 5 years ago

Can you change this to be a PR against develop branch (create develop from master if it doesnt exist) and push to brapi-dev on kubernetes so we can compare.

tcnichol commented 5 years ago

I may have some deprecated methods left in, so I will check this carefully myself. If anyone else can check, let me know.

max-zilla commented 5 years ago

@max-zilla will check this and we can merge soon.