terraref / computing-pipeline

Pipeline to Extract Plant Phenotypes from Reference Data
BSD 3-Clause "New" or "Revised" License
21 stars 13 forks source link

Confirm that plot boundaries for sorghum crop 2 generated from field scanner coordinates are consistent with those based on RTK GPS #187

Closed dlebauer closed 7 years ago

dlebauer commented 7 years ago

Update: they don't match, so will make new polygons. https://github.com/terraref/computing-pipeline/issues/187#issuecomment-256760060 below:

For reference, we have two sets of polygons

  1. those made by @tingli3 based on gantry measurements (transformed from gantry xy) these are already in BETYdb and can be queried as json here: https://terraref.ncsa.illinois.edu/bety/api/beta/sites?sitename=~Season+2&limit=none&key=
  2. those made by @anfrench, used by @rickw-ward and exported to json by @Mamatemenrs .

(current hypothesis) The reason these differ is that (1) were two row plots and (2) were the same plots after they were a) combined into four row plots, and b) subset to just the inner two rows. (2) should be used for summarizing plot level metrics since they exclude border rows.


FYI (@robkooper and @gsrohde) this is where we will need to begin combining sites using the geometry field (related to PecanProject/bety#444) ... so if someone queries for plot 1 they can find all contained or intersecting points and polygons. Developing these queries can wait until we have data and more specific use cases.


We should confirm that these are in alignment

dlebauer commented 7 years ago

We can have many ways to define plots - single, double, quadruple rows. This should be driven by use cases, only different when necessary, and hierarchical where possible. So if you define the plot shapes and names we can generate them.

dlebauer commented 7 years ago

@rmgarnett FYI