terraref / computing-pipeline

Pipeline to Extract Plant Phenotypes from Reference Data
BSD 3-Clause "New" or "Revised" License
21 stars 13 forks source link

Handling FLIR and hyperspectral changed positions #496

Closed craig-willis closed 5 years ago

craig-willis commented 6 years ago

Motion enabled and FLIR relocated today. Tomorrow: hyperspctral install in new locations.

Fixed metadata needs to handle dates.

max-zilla commented 6 years ago

the fixed metadata should have another level with dates.

2 parts 1) update https://github.com/terraref/sensor-metadata/blob/master/sensors/flirlrCamera/sensor_fixed_metadata.json and VNIR/SWIR for hyperspectral to contain 2 copies of the JSON metadata with a key for start date.

2) in clean metadata: https://github.com/terraref/terrautils/blob/master/terrautils/lemnatec.py#L168 this should not return the entire JSON but instead only return the sub JSON matching the date of our dataset. might need to add date parameter here: https://github.com/terraref/terrautils/blob/master/terrautils/lemnatec.py#L78

max-zilla commented 6 years ago

Here is example RAW metadata before cleaning: metadata.json.txt We can fetch the date out of this stuff.

NewcombMaria commented 6 years ago

@craig-willis and @max-zilla Draft versions of the fixed metadata with revised offset are now uploaded in a new folder on google drive: https://drive.google.com/drive/folders/1IF9JjUgWHA77Q5FkEf5ON-G49X35o9r5

The PS2 and 3dScanner files did not change. The date of the offset change is not included within the Draft files for instruments with new offsets - the file name has the date of the revision. Let us know if this will work for the pipeline or not. We can make changes as needed.

max-zilla commented 6 years ago

https://github.com/terraref/sensor-metadata/pull/10/files

max-zilla commented 6 years ago

@NewcombMaria are the locations here: https://drive.google.com/drive/folders/1IF9JjUgWHA77Q5FkEf5ON-G49X35o9r5

the locations that went into effect before season 6? I don't recall thinking that these were moved at all last week so we're assuming the locations in Drive are the locations to apply starting 2018.

@tcnichol these are the other locations we want to update in your PR.

max-zilla commented 6 years ago

make the sensor JSON files into a list of objects, each has a "start_date": "xyz" field inside the object, iterate through and check:

NewcombMaria commented 6 years ago

@max-zilla the new positions in the fixed metadata files are for the camera relocations, work completed end of the day 2018-08-18 (between seasons 6 and 7). The new locations are for the following instruments: FLIR, SWIR, VNIR, CropCircle, NDVI, PRI, and also StereoTop (RGB). We will start scans for season7 this weekend (3d lasers) and after planting (weather permitting), with cameras in new locations.

tcnichol commented 6 years ago

Okay, so I have changed FLIR, SWIR and VNIR. I just fixed the start dates in those, and I will fix the rest of the metadata this weekend. Max, that should all be done by Monday morning for you to review.

tcnichol commented 6 years ago

I think I have fixed all the sensors that have changed now.

max-zilla commented 5 years ago

merged. followup in #502