terraref / computing-pipeline

Pipeline to Extract Plant Phenotypes from Reference Data
BSD 3-Clause "New" or "Revised" License
21 stars 13 forks source link

Problems with get_child_collections in Terrautils extractors.py #594

Open Chris-Schnaufer opened 4 years ago

Chris-Schnaufer commented 4 years ago
Title: There are several issues with get_child_collections() Tags: terrautils, extractor, get_child_collections ### Description There are some problems around the get_child_collections() function in terrautils/extractors.py 1. It's defined multiple times 2. There are calls (in extractors.py) to the function that are passing in a user name and password instead of a key (a key is what's expected) ### Details The calls to get_child_collections() in delete_dataset_metadata_in_collection and delete_datasets_in_collection will fail at run time. The two declarations with the same name will result in only one or the other being active at run time. There's enough difference in intent between the two declarations that unexpected results may occur ### Completion Criteria * [ ] Only one instance of get_child_collections() is defined * [ ] The calls to the function that have too many parameters are corrected, or another function is defined to handle their case