search

terraref / extractors-stereo-rgb

Scripts and code relevant to the 8MP RGB stereo 3D cameras.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Rgb enhancement #44

Closed tcnichol closed 5 years ago

tcnichol commented 5 years ago

Not sure how to handle moving the methods inside of the extractor class. When I attempted to move them inside it appeared that methods were not finding the other methods called by them.

max-zilla commented 5 years ago

Not sure how to handle moving the methods inside of the extractor class. When I attempted to move them inside it appeared that methods were not finding the other methods called by them.

if i understand correctly, then we dont need to have all the methods inside the extractor class (which would mean any calls to them would have to be self. prefaced) so having them outside is fine. in this case moving them inside the class just adds more complexity so let's skip it. also makes it easier to move those methods to a science package later if we decide that makes sense. will leave some other comments in the code.