search

terraref / extractors-stereo-rgb

Scripts and code relevant to the 8MP RGB stereo 3D cameras.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Update README.md #46

Closed Paheding closed 5 years ago

Paheding commented 5 years ago

Add the description of the RGB image quality enhancement extractor.

dlebauer commented 5 years ago

This is a great first step, but could you please add an algorithm description in the README under the canopy-cover-enhancement folder extractors-stereo-rgb/canopy-cover-enhancement/readme.md with sections such as authors, overview, algorithm description, quality statement, references, related issues, and further reading?

There are a few others that @ZongyangLi wrote, for example the canopy cover extractor in extractors-stereo-rgb/canopycover/README.

Paheding commented 5 years ago

please add more comprehensive algorithm description as canopy-cover-enhancement/readme.md

Yes, I have requested a full to create a folder in extractors-stereo-rgb. Once it's approved, I will write a comprehensive readme file, as well as uploading the extractor code, test code/image/results, etc.

dlebauer commented 5 years ago

the file already exists, doesn't it? Don't you have permission to update this file https://github.com/terraref/extractors-stereo-rgb/edit/master/canopy-cover-enhancement/readme.md?

Paheding commented 5 years ago

the file already exists, doesn't it? Don't you have permission to update this file https://github.com/terraref/extractors-stereo-rgb/edit/master/canopy-cover-enhancement/readme.md?

It seems I do not have permission, I tried to update it but it asks me to create a pull request and approval. I have assigned you as a reviewer.

Paheding commented 5 years ago

@dlebauer My suggestion is that put this extractor into a separated folder (maybe named as "image_quality_enhancement") and then I can put upload related materials into the folder.

dlebauer commented 5 years ago

Sorry, I wasn't clear that this was a different extractor ... if it is, it makes sense to create a new directory.

Paheding commented 5 years ago

Sorry, I wasn't clear that this was a different extractor ... if it is, it makes sense to create a new directory.

Thanks, I have created to a pull request to open a new folder.