terraref / reference-data

Coordination of Data Products and Standards for TERRA reference data
https://terraref.org
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Different stereo cameras installed in camera box 2018-01-25 #224

Open NewcombMaria opened 6 years ago

NewcombMaria commented 6 years ago

After yesterday's hardware test for the stereo-vis y-axis velocity problem that has been ongoing during this current season 5, we determined that the problem has been caused by a fault with one or both of the stereo cameras. Today Stuart, John, and I will replace both of the stereo cameras with two that had formerly been on the gantry side-arm, keeping the original lenses but replacing the cameras.

We will update the metadata, adjust the camera settings, and go through all procedures necessary to ensure data quality. @dlebauer (and/or anyone: @JeffWhiteAZ) please provide advice/input to ensure that we complete all steps necessary for replacing instruments. Please add/comment on the bullets below:

max-zilla commented 6 years ago

@craig-willis FYI we should have this on radar.

max-zilla commented 6 years ago

This is the stereo RGB current fixed metadata: https://github.com/terraref/sensor-metadata/blob/master/sensors/stereo/sensor_fixed_metadata.json

@craig-willis @dlebauer and I should discuss. we need to adjust this fixed JSON object to support by-date references so we can route the dataset to correct sensor metadata based on when the dataset was captured

max-zilla commented 6 years ago

@smarshall-bmr should make a pull request with edits to this XML file: https://github.com/terraref/lemnatec-fixed-metadata/blob/master/stereoCameraBox.xml

we will then update the JSON file and code to reflect these changes (supporting multiple date ranges/multiple calibrations)

NewcombMaria commented 6 years ago

Latest update: it turns out that the installation of the 2 alternative cameras did not result in a sustainable fix. After time on the afternoon of 25 January the scan even with the new cameras faulted by server problems. For a while today Stuart tried one old camera and one new camera and updated camera settings and it was working well for a while but just recently the server drops returned. For now the camera re-installation is on hold and it's uncertain which cameras will be selected for the long run.

NewcombMaria commented 6 years ago

Data from the afternoon of 2018-01-24 through mid-day 2018-01-29 will need careful attention to edit metadata for data that should be kept, especially 2018-01-27, 01-28, and morning of 01-29 which are days/times with good data but with the serial number of one of the stereo cameras incorrect which will need to be edited in metadata. Some times/days the data will need to be noted as ERROR when we were running tests for diagnostic testing only and the camera lenses didn't match up.

Starting today at 11:45 AZ time, (2018-01-29 11:45), the original cameras in original positions were connected and are currently running to match with the metadata serial number settings. It appears likely that cameras were not the problem. Markus Radermacher (LT) provided a software revision that initiates image fetching in the software and disabled all wago IO device interaction and so far today Stuart is running the scan at optimal speed (0.33 m/s) without server drops and without losing images.

dlebauer commented 6 years ago

@NewcombMaria so ... in the end the cameras were not switched? can we close this, or is there anything else we need to do?

NewcombMaria commented 6 years ago

@dlebauer the only remaining item that needs follow-up is that the data and metadata from the afternoon of 2018-01-24 through mid-day 2018-01-29 needs either metadata correction for some data-sets or for other data-sets the data itself needs 'ERROR' notation.

Some of the scans that were run in that time-frame generated data that should either be deleted or marked clearly by "ERROR" (for example when one camera in the stereo pair had one type of lens and the other stereo-paired camera had a different lens). However the data collected on 2018-01-27 and 2018-01-28 and the morning of 2018-01-29 are reasonable data but need notation in the metadata that one of the two stereo cameras had a different serial number. I'll need to find out the correct serial number and if it was the south or north camera.

Will update with more details soon.

dlebauer commented 6 years ago

@NewcombMaria thanks! if you could just provide a bulleted list of what needs to happen for what date ranges, we can implement.

NewcombMaria commented 6 years ago

@dlebauer here's a list by dates for StereoTop data files from StereoVis scans. Let me know if you have follow-up questions: