search

terraref / traitvis-webapp

Shiny application for visualizing trait data
https://traitvis.workbench.terraref.org/
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Add url parameter support #45

Open kimberlyh66 opened 5 years ago

kimberlyh66 commented 5 years ago

Allow users to search for a specific map, plot, and management timeline by supplying url parameters (experiment name, sub experiment name, trait name, cultivar, and date).

dlebauer commented 5 years ago

please separate into different files

kimberlyh66 commented 5 years ago

Output render functions have been removed from app.R and placed into separate files (either render-home-outputs.R or render-search-outputs.R depending on if render function is for home or search page) to improve organization of code.

Chris-Schnaufer commented 5 years ago

Waiting on review of Pull Request

dlebauer commented 5 years ago

Probably needs to be refactored; could take the opportunity to implement a shiny package using the golem framework https://github.com/ThinkR-open/golem

Chris-Schnaufer commented 5 years ago

Needs discussion and investigation: Investigate Golem for packaging the changes made; new functionality were added. It's not clear that the current approach is best. Perhaps Kristina and Emily collaborate on reviewing this. Create a ticket to look into creating issues for bugs? David: Kristina spend a day trying this out and documenting found problems