terrarium-earth / Chipped

Adds 10,000+ building blocks to Minecraft! Because every block needs a friend!
Other
70 stars 37 forks source link

[Feature Request]: Make CTM an optional dependancy #175

Closed ground-fruit closed 1 year ago

ground-fruit commented 1 year ago

Is your feature request related to a problem?

One of CTM's config options is to disable connected textures entirely. It seems silly to have to install a whole mod to disable the feature.

I know very little about the internals of these mods or if this is feasible.

Solution(s)

Suggestion: Make CTM an optional dependency, and load Chipped's un-connected textures when CTM is not installed.

Describe alternatives you've considered

Disabling connected textures is a solution to the incompatibility with Supplementaries: https://github.com/CodexAdrian/ConnectedTexturesMod-Fabric/issues/1

Mod Version

Chipped Fabric 2.1.0

CTM Fabric 1.0.0 1.19.2

Supplementaries 1.19.2-2.2.50

Mod Loader Version

Fabric 1.19.2 - 0.14.13

Mod Loader

Fabric

Lunarck commented 1 year ago

I'm also dealing with this issue and sadly this fix isn't working. I tested it on a clean world as well. If you know any other way, I'd love to know, thank you!

ground-fruit commented 1 year ago

I'm also dealing with this issue and sadly this fix isn't working. I tested it on a clean world as well. If you know any other way, I'd love to know, thank you!

Did you restart the game entirly after disabeling CTM? You’ll need to do this because the error has to do with the registry, which is not reloaded with f3+T (Devs, correct me if I’m wrong)

Lunarck commented 1 year ago

I did. I set Disable CTM to TRUE and the texture still continues to be missing on my clean world. I'm not sure why.

Chipped 2.1.1

CTM Fabric 1.0.0

Fabric API 0.75.1

MoonlightLib 2.2.13

Resourceful Lib 1.1.22

Supplementaries 2.2.53

AlexNijjar commented 1 year ago

it's made a required dependency as many of chipped's blocks are broken without it. technically you don't need it but we don't want people downloading it to be confused when many of the blocks have broken textures

Lunarck commented 1 year ago

Can this issue be fixed?

I asked about this in the Supplementaries Discord and the developer said it was an issue with CTM Fabric.

LucasOe commented 1 year ago

On Fabric you can override the dependents yourself inside config/fabric_loader_dependencies.json:

{
  "version": 1,
  "overrides": {
    "chipped": {
      "-depends": {
        "ctm" : "IGNORED"
      }
    }
  }
}
Lunarck commented 1 year ago

Thank you, I will try this!

Lunarck commented 1 year ago

So far it has been working in my game! Thank you so much!

CodexAdrian commented 1 year ago

Seems as though you found a solution. CTM will continue to be a required dependency as many of our blocks do not work without it. The issue with rendering is not on chipped, but on CTM for Fabric, which I will address.