[Bug]: Blocks not being created using a glassblower's workbench

caileacat commented 10 months ago

Bug Description

I'm trying to use the Glassblower's Workbench to make Large Diamond Leaded Glass, but when I try to pick it up from the right side, it just disappears. The number of glass in the left side drops by one for a split second before updating back to the original number I had before attempting to make that item.

In addition to the block I mentioned, it looks like there are others that don't work (aren't created when using the station) also..?

I tried using console commands, and I was able to gift the blocks manually. But this solution isn't ideal, as we prefer to not have to resort to such things in our servers/worlds (we've had issues with people abusing this power in the past).

How to Reproduce?

1) Go to glassblower's workbench 2) insert glass in the left side 3) attempt to use the station to create Large Diamond Leaded Glass 4) see the new blocks in the right side of the workbench, from where you'd normally pull them to your inventory 5) attempt to pull them to your inventory 6) see the block you just tried to move simply disappear and the number of glass available in the left side of the station return to the original amount

Expected Behavior

1) Go to glassblower's workbench 2) insert glass in the left side 3) attempt to use the station to create Large Diamond Leaded Glass 4) see the new blocks in the right side of the workbench, from where you'd normally pull them to your inventory 5) attempt to pull them to your inventory 6) you now have the block you tried to create

Version

3.0.1

Mod Loader Version

1.20.1

Mod Loader

Forge

Logs or additional context

In case this is relevant, I'm using BMC4. This mod is part of that modpack.

Code of Conduct

[X] I have searched the issue tracker and confirmed that the issue has not been reported
[X] I have checked the FAQ (if one is present) and my issue is not listed
[X] I have verified that I am using the latest version of the mod
[X] I have verified that I have installed all the required dependencies for the mod
[X] I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.

gardenappl commented 10 months ago

I'm experiencing a similar thing with the Every Compat mod installed. It adds an insane amount of glass pane variations which makes the crafting glitch out in the way you describe. https://github.com/terrarium-earth/Chipped/issues/238

So you're saying you're having the same issue even without Every Compat?

coolsa commented 8 months ago

I encountered this issue too on the Better Minecraft modpack, on Forge 1.20.1. Did some digging, and it seems that it happens after 128 items. This seems to be caused by class net/minecraft/network/protocol/game/ServerboundContainerButtonClickPacket, which is used to send the selected glassblower item to the server, but it is encoded and decoded as a byte.

terrarium-earth / Chipped