terrarium-earth / Handcrafted

Turn your house into a home!
https://modrinth.com/mod/handcrafted
Other
16 stars 20 forks source link

[Bug]: Top texture for wooden tables have upside down UV. #124

Open gclooa opened 1 month ago

gclooa commented 1 month ago

Bug Description

Misaligned textures. image

How to Reproduce?

Place down any wooden tables next to any other block using vanilla wooden plank textures.

Expected Behavior

UV should be inverted.

Version

3.0.6

Mod Loader Version

1.20.1

Mod Loader

Fabric

Logs or additional context

No response

Code of Conduct

Khazoda commented 3 weeks ago

I've made a PR that partially addresses this bug. It fixes the table, which doesn't have a facing property:

image

The trouble with the other blocks that do have a facing property is that the UVs need to be different for every direction. This can be achieved with blockstates, but blockstates can get too complex very fast with multiple properties (The table is 1636 lines of JSON because it has 3 different properties, with shape being the biggest).

Desks and Nightstands already have the facing property in their blockstates to denote model rotation, so the fix would simply involve adding 3 more models per block and referencing those models in the blockstate for each different facing direction.

If @terrariumearth thinks this is a good idea, I will go ahead and make another PR with those fixes, so please let me know (and tag me in the comment) Thank you!