terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
35 stars 19 forks source link

quest event api draft #104

Closed finasera closed 1 year ago

finasera commented 1 year ago

Thanks to @sisby-folk for the pointers in Discord.

Another possible refactor: including the quest ID in the actual quest object. All names here are bikesheds, and feedback's appreciated!

Ref: https://discord.com/channels/880995984426020885/1112838989817319574/1162997843271893023

ThatGravyBoat commented 1 year ago

Hello, you seemed to of used Architectury API we do not use that in our projects the reason you can "use" it is because of our REI compat you can copy how we do events in our other mods here https://github.com/terrarium-earth/Prometheus/blob/1.20.x/common/src/main/java/earth/terrarium/prometheus/api/events/MemberRolesChangedEvent.java

finasera commented 1 year ago

Thanks for the review!