When using the Recipe Task to complete a task upon crafting an item, the current implementation is triggering upon the unlocking of how to craft a recipe (see vanilla toast implementation) rather than upon the required item being crafted. This appears to be due to hooking in to ServerPlayerEntity#triggerRecipeCrafted rather than Item#onCraftedBy. Given the current nomenclature that is used, the Recipe Task was understood to trigger upon crafting an item via its recipe. Whilst this might be a misunderstanding on our part, it is my suggestion that either the nomenclature be changed to be more clear or the mixin targeted method be changed to the aforementioned suggestion.
How to Reproduce?
Create a Recipe Task Quest
Gather the ingredients needed to craft the item in the task
Gain completed task without crafting the item
Expected Behavior
The task should trigger when the item is crafted via its recipe, rather than when the requisite ingredients are gathered.
Version
1.0.5
Mod Loader Version
1.20.1
Mod Loader
Fabric
Logs or additional context
No response
Code of Conduct
[X] I have searched the issue tracker and confirmed that the issue has not been reported
[X] I have checked the FAQ (if one is present) and my issue is not listed
[X] I have verified that I am using the latest version of the mod
[X] I have verified that I have installed all the required dependencies for the mod
[X] I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.
Bug Description
When using the
Recipe
Task to complete a task upon crafting an item, the current implementation is triggering upon the unlocking of how to craft a recipe (see vanilla toast implementation) rather than upon the required item being crafted. This appears to be due to hooking in toServerPlayerEntity#triggerRecipeCrafted
rather thanItem#onCraftedBy
. Given the current nomenclature that is used, theRecipe
Task was understood to trigger upon crafting an item via its recipe. Whilst this might be a misunderstanding on our part, it is my suggestion that either the nomenclature be changed to be more clear or the mixin targeted method be changed to the aforementioned suggestion.How to Reproduce?
Expected Behavior
The task should trigger when the item is crafted via its recipe, rather than when the requisite ingredients are gathered.
Version
1.0.5
Mod Loader Version
1.20.1
Mod Loader
Fabric
Logs or additional context
No response
Code of Conduct