search

terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
35 stars 19 forks source link

Tiles the background from a resource image. #125

Closed SubordinalBlue closed 1 year ago

SubordinalBlue commented 1 year ago

The resource file 'header.png' has unused space. This uses the bottom left 128x128 square of that resource.

Critique: I'd rather this feature respected the alpha channel of the png.

SubordinalBlue commented 1 year ago

After tiling-the-backrgound-with-alpha, a fall back enhancement, imho, would be reading a color value with alpha to fill the background with. Currently the background fill color is hard-coded.

SubordinalBlue commented 1 year ago

Fixed to respect/utilize the alpha channel of the source resource. Hat tip to Herrah. TY.

sisby-folk commented 1 year ago

Looks like it needs a little TLC still.

image

might also want to consider using a different texture for the left pane vs main pane.

you've also got some accidental wacky indentation here and a space missing after a comma:

image

SubordinalBlue commented 1 year ago

Odd, about it not showing anything for you. The updated heading.png did go in the second commit.

Good idea about separate background treatment for the side bar; I'll look into that.

Will fix the white-space issues next commit.

SubordinalBlue commented 1 year ago

"Doh" on placing the new heading.png in the wrong place. Test instance had covered up my mistake.

SubordinalBlue commented 1 year ago

On the matter of treating the side bars (groups and single quest view, and perhaps the edit stuff on the right side)... I see all those widgets subclass AbstractQuestScreen, and weren't overriding to do their own background drawing.

So, perhaps that should be a separate PR. What do you think?

SubordinalBlue commented 1 year ago

Looks great to me, your changes. TY!

sisby-folk commented 1 year ago

Looking good for a second round now.