terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
35 stars 19 forks source link

[Bug]: Tasks in locked quests do not progress #148

Closed sisby-folk closed 9 months ago

sisby-folk commented 11 months ago

Bug Description

When a quest is locked, its tasks don't track progress - this means that exploration quests will stay incomplete if their dependency isn't completed first, even if you've already visited that dimension/biome structure.

It also means that item quests for items you already have wont complete, requiring you to drop them and pick them back up.

How to Reproduce?

No response

Expected Behavior

Tasks should track their own progress while the quest is locked. Ideally, this is done via a default-on setting for quests, so that quests like "kill 10 creepers" can still require the player to kill exactly 10 after sighting the task as being unlocked.

Version

1.1.6

Mod Loader Version

0.20.2

Mod Loader

No response

Logs or additional context

There are still technical limitations with the suggested solution. For a "do not progress while locked" quest, item tasks are still not updated when the quest is unlocked, leading to the "drop and pick up" problem. Ideally, item tasks should be able to be forced to check the whole inventory, which can be triggered whenever a quest becomes unlocked.

Code of Conduct

sisby-folk commented 9 months ago

@ThatGravyBoat I saw this got fixed for stat and advancement tasks, do you still need to drop and re-pick up items when acquire item tasks unlock that you already have the items for?