terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
35 stars 19 forks source link

[Bug]: Removing a Quest does not remove the dependency from other quests #170

Closed Auseawesome closed 7 months ago

Auseawesome commented 10 months ago

Bug Description

If you delete a quest before removing the dependency, the dependency stays but can't be seen in the dependency viewer.

This means it has to be removed in a an external text editor

However, it bugs the rendering of all tabs of the quests that have a bugged dependency, meaning they cannot be used or viewed until this bugged dependency is removed

How to Reproduce?

  1. Create 2 quests
  2. Make 1 a dependency of the other
  3. Remove the quest that is the dependency
  4. Other quest's rendering is now bugged

Expected Behavior

Automatically deletes the dependency as it is no longer there

Version

1.1.8 Dev Build (Built at 19:20 27/01/24)

Mod Loader Version

47.1.96

Mod Loader

NeoForge

Logs or additional context

heracles.zip - Zipped version of my quests showing the bug.

This happened when I was recreating a bunch of quests to get rid of the randomly generated IDs that happens when converting from FTB quests.

Code of Conduct