terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
35 stars 19 forks source link

[Bug]: Changing items in item tasks does not update nbt #220

Open Electrolyte220 opened 7 months ago

Electrolyte220 commented 7 months ago

Bug Description

When replacing an item with nbt in an item task with a different item, the new item retains the nbt from the old item, so you have to remove the task and make a new one.

How to Reproduce?

  1. Make a quest with an item task
  2. For the item task, use any item with nbt
  3. Try to replace with another item that either has no nbt or different nbt
  4. Observe the item now has the nbt from the old item

Expected Behavior

The nbt is removed and replaced with the new item's nbt (if present).

Version

1.1.12

Mod Loader Version

1.20.1 - 47.2.17

Mod Loader

Forge

Logs or additional context

No response

Code of Conduct