terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
34 stars 19 forks source link

[Feature Request]: Change "collectionType" to "collection" #226

Open FooterManDev opened 5 months ago

FooterManDev commented 5 months ago

Is your feature request related to a problem?

Not really, This is really just a little thing that bothers me. I mistakenly used collectionType for the Item task, in a JSON Schema I made, which was improper.

In Quest JSON, the XP task uses collectionType as the field name, while the Item task uses collection as the field name, for setting how the task is completed. These should be the same name, as they do the exact same function.

Please disregard my original comment before the edit, I suck at reading.

Solution(s)

Rename the XP task's collectionType field to collection, for parity with the Item task.

Describe alternatives you've considered

Or, the other way around.

Mod Version

1.1.12

Mod Loader Version

20.1 - 47.2.0

Mod Loader

Forge

Additional context