search

terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
29 stars 16 forks source link

[Feature Request]: For task items with NBT, allow for "equal to or greater" (or lesser) behavior #234

Closed SubordinalBlue closed 3 months ago

SubordinalBlue commented 3 months ago

Is your feature request related to a problem?

Prompted to suggest this for our easier/basic TerraShatterer quest.

The hard quest is a simple matter... the NBT for that one specifies the maximum mana a TerraShatterer can have, it's easy for the player to hit that exact number.

For the easier/basic "Terra Tools" quest, a much lower, non-zero amount would be nice: they player the still has to charge the tool at least somewhat with mana... which is a key part of what makes the Terra Shatterer different than a regular pickaxe.

In FTBQ/AoF6, the quest would satisfy with any TerraShatter with a mana amount greater or equal to the amount specified in the quest file.

A similar behavior/ability for Heracles would be nice. I imagine more uses could be made of it than just this one quest I've used to illustrate the matter.

Solution(s)

No response

Describe alternatives you've considered

No response

Mod Version

latest

Mod Loader Version

Fabric

Mod Loader

No response

Additional context

No response

ThatGravyBoat commented 3 months ago

While I like the idea this will be come obsolete instantly when we upgrade to 1.21 so I think this change would be too much effort for not much gain

CodexAdrian commented 3 months ago

In 1.21 mojang has added "ComponentPredicates" that will enable much more flexible component matching, we'll likely end up using it in heracles