terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
29 stars 16 forks source link

Add config to disable book/barrier registration, add null checks #236

Closed sisby-folk closed 2 months ago

sisby-folk commented 3 months ago

would close #235 as completed.

Adds a heracles-common-options.json that allows disabling the registration of the quest book and barrier.

The primary purpose for this is modpack and server flexibility. Configured right, this lets vanilla clients connect to a heracles server, as well as completely remove quest barriers from /fill and the book from /give. FTB struggles from a lot of feature bloat - and we consider its set of knicknacks in the registry to be part of that, so if we continue to use heracles, we'll use it with these configs off - merged or hardfile forked.

Cases Tested:

Limitations:

CodexAdrian commented 3 months ago

Like I said, this isnt something we want to do. If feature bloat is a genuine concern, then a better solution would be to separate out this feature into a new module, not make them configurable. Thats something we'd be willing to do when Heracles gets ported to 1.21

sisby-folk commented 3 months ago

I'd definitely be happy with a split solution - it seems like y'all are interested in making the GUI optional as well for the vanilla client case, so it makes sense. We'll probably just leave our pack on 1.1.12 unless there's a fix we really need for 1.20 - then we can merge that into this and it's all dandy anyway.