terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
35 stars 19 forks source link

[Bug]: EMI buttons render on the Quests screen #30

Closed lumiscosity closed 1 year ago

lumiscosity commented 1 year ago

Bug Description

The EMI config and recipe tree buttons appear on the quests menu.

How to Reproduce?

Install EMI and open the quests menu.

Expected Behavior

The buttons do not appear.

Version

0.0.2

Mod Loader Version

1.20.1, 0.14.21

Mod Loader

Fabric

Logs or additional context

"currently EMI will render in any HandledScreen. why are they using a HandledScreen" - Emi, when contacted about the bug (idk what any of that means i haven't touched a line of minecraft mod code before)

Code of Conduct

ThatGravyBoat commented 1 year ago

You can tell emi I wanted it so that I could have it synced and know when a GUI was open but a lot of mods seem to not check if a menu actually has slots so I will just change it to a screen like I said in the other issue, if you encounter anymore issues with mods showing up in the screen please do not report it to the repo or them because it is like a 99% chance the same bug

ThatGravyBoat commented 1 year ago

ill have a fix for it in a few

ThatGravyBoat commented 1 year ago

but so I dont forget to close both duplicate of #29