[Bug]: Crafting quests don't complete properly - Githubissues

terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users

MIT License

35 stars 19 forks source link

[Bug]: Crafting quests don't complete properly #64

Closed EcksTree closed 1 year ago

EcksTree commented 1 year ago

Bug Description

After fulfilling the requirements to complete a crafting quest, the task says completed, but the quest stays unfinished.

How to Reproduce?

Create a quest that requires a recipe to be crafted
Craft said recipe
Check the quest's 'Task' tab and notice that it's 100%
Also notice that the quest itself is not complete

Expected Behavior

Expected to be able to complete the quest properly when all conditions are fulfilled.

Version

1.0.4

Mod Loader Version

1.20.1 - 47.1.44

Mod Loader

Forge

Logs or additional context

No response

Code of Conduct

[X] I have searched the issue tracker and confirmed that the issue has not been reported
[X] I have checked the FAQ (if one is present) and my issue is not listed
[X] I have verified that I am using the latest version of the mod
[X] I have verified that I have installed all the required dependencies for the mod
[X] I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.

bellebucane commented 1 year ago

i am also having this problem, the item is crafted but i have no way of submitting or detecting the item to complete the task

sisby-folk commented 1 year ago

On the main commit, I can't replicate this issue - once 1.0.6 (or 1.1, idk what it'll be called) is out, check this issue again.

ThatGravyBoat commented 1 year ago

This was fixed in https://github.com/terrarium-earth/Heracles/commit/3160cb3e5c30872820964f061b10423d4a62f10a