sisby-folk
commented
1 year ago Pins!
Release:
PR:
Looks good, but the titles that are the same for entire types like "submit xp" and "complete an advancement" falter. My previous proposition to just merge titles and descs for these, or a third formatter made for pins, would both work. Outside of the scope I'm comfortable in for the PR though.
If neccesary, I can try my hand at implementing a workaround for the three shown cases specifically - but it'll be more odd use of the title formatters.
Addresses #75 - most edits are covered there, though some small adaptations were made to better fit what's in the code.
Some later-refactorable oddities are included - including switching the title and description in code instead of in language keys (bad) - this is due to TaskTitleFormatter being the way that it is. It could be removed to resolve this, or just these specific formatters.
Before:
After: