terrarium-earth / Heracles

A tree style questing mod allowing creators to set completable quests for their users
MIT License
35 stars 19 forks source link

[Bug]: Sound spamming in composite quests #81

Closed LZ1WS closed 10 months ago

LZ1WS commented 1 year ago

Bug Description

When you complete a composite quest with two OR goals in it, it spazzes out and starts spamming you with notifications about completion

How to Reproduce?

  1. Create composite quest with two items (gathering)
  2. Obtain that item
  3. Get spammed by notifications and sounds
  4. Eargasm

Expected Behavior

One time notification upon completion

Version

1.0.5

Mod Loader Version

1.20.1

Mod Loader

Fabric

Logs or additional context

No response

Code of Conduct

LZ1WS commented 1 year ago

It's also happened with regular quest, it seems that it happens with new quests sometimes, I just joined a world and got blasted by unlock sound of a quest that I couldn't get before due to it's late addition

bluebear94 commented 1 year ago

I can’t reproduce this on 05a40ea.

SubordinalBlue commented 1 year ago

I can reproduce this, reliably, on release 1.1.0. If I complete any composite task it will happen, whether or not the task uses vanilla items or fancy ones with nbt. any_vanilla.json