Closed sisby-folk closed 1 year ago
Working much nicer now. Only needs to be applied to all types now which is kind of scary prospect.
Just putting these values on all tasks and reward types like I have for gather is entirely viable, but i'll admit it feels like a mess. Then again, they all have duplicate code for rendering item icons, so why not! I'll see if I can do any better than that afterwards.
https://github.com/terrarium-earth/Heracles/assets/55819817/b6883d95-90aa-441a-8d3f-c0000d72fa1a
This one should be ready - all task and reward types that had registered settings have title and icon overrides now. That only leaves out the technical or data-only types - locationtask, compositetask, and selectablereward.
I didn't touch title formatters because pinned quests are still pretty indev and need other tweaks anyway.
things to fix i noticed today: toasts are broken!
also locationtask needs its stuff updated to match the new dummy codec.
I believe we're dusted! feel free to check it
Closes #65
š Yea we're like 1/3 as confident going through this as the last howevermany - so this'll be a slow rolling draft
Starting with the gather task as a PoC - Task title is basically mint as-is, but icon needs some work.
https://github.com/terrarium-earth/Heracles/assets/55819817/133a66b5-9d26-4986-a9c2-9014b9a670e8
To do:
Also incidentally fixes dependency icon sizing.
The rendering for icon sizing is a bit of a mess at the end of this one - the concept of a "task/reward/quest icon" could probably be generified to be used interchangeably, scaled, and repositioned. That way, quest icons can fall back to task icons, similar to this override, and they can be rendered in eachothers spaces. Could implement things like a "tag icon" that changes between stacks, unify the "item icon" used in many tasks with the one used for questIcon, etc.