Open asanjabi opened 1 year ago
ah i didn't realize this wasn't working in d2 preview.
indeed, i suspect that this extension is passing in default values through the CLI, which takes priority. Instead, they should be omitted, which will let the variable configurations take priority over default values
@alixander So the solution is to have a "none" option in the theme and sketch options, that would then omit the CLI options? What about layout?
I think the same pattern would work for layout also, I'd love to see that as an option :)
@alixander So the solution is to have a "none" option in the theme and sketch options, that would then omit the CLI options? What about layout?
No the solution is to just omit the flags if they are default.
setting render layout engine per document is crucial obviously, a lot of hassle brings that vars not working as expected. Curios why it's working correctly on d2 Playground, which is also VSCode based
We started playing with the vscode extension but ran into this as well, we locally edited the extension to make this work but this is obviously not a sustainable solution, imo the vscode settings should not override the project settings.
If there a none option in the settings, then user would have the option of setting these values through the variables per document. Or maybe an option for the CLI to reverse the override priority to document over CLI parameters.