dagre: set rank better for container-container edges

terrastruct / d2

D2 is a modern diagram scripting language that turns text to diagrams.

https://d2lang.com

Mozilla Public License 2.0

18k stars 441 forks source link

dagre: set rank better for container-container edges #1009

Open alixander opened 1 year ago

alixander commented 1 year ago

i think we can do this a lot better actually by using this minlen

https://play.d2lang.com/?script=zFNNb5wwFLz7V0w3am9hUbRVJB8qseCkkbqAgO2pF3fjZi2ZD2HTtKr47xXmcxN6bm54_Dxv3sxj8pzisXwuSJxEwdFnCcUfAtge_ScwPaQwdSMsNjtN8XyWZkClUhTf1VB0ETnFbnpJkZdFSYCWtGRqjetP4JUkhFeSwosfELD04T7EBwTsK_sSxQcWZr2-zmwKI36ZUa2zIG4J0aezyDnFZmMfxEmURfvjHVL_Mzt442jdOlCcjak03W67k3aMqGuuTd2cjHMq863QWhRGcqXf39zdfLy9_iGVcPTPJ8swKJE5f-qHfiWmmxLgWgujx7527SisoGMcR0kGLwy-FfcsZImXsQBemrIs_RfjBFrD5wDm0jGcKYz-arlNFK69GQ471x20vjDL5nIhv-ca_oaexibJK9kV9947L2jGTLoKPwrT44El8NbA_RroE3IFv2zUI2rBlfqNRgvoMhc4qU6efkdm2sUaXzq39G1z5bquu7vdTPjKxr62dLR73dF2VrF_Eyr8_6nibwAAAP__&layout=dagre&

alixander commented 1 year ago

https://github.com/terrastruct/d2/pull/1011 does a lot, but i still think this has potential to improve somehow, with the above property. specifically, the case where container A points to container B but container B also points to container A