Closed alixander closed 8 months ago
Hi team I want to contribute to this story. I'm very new to open source. I think this looks like a good place to begin. Can I start working on this?
@aakashdeepsil All yours!
Perhaps @Paracelsus-Rose's PR on https://github.com/terrastruct/d2/pull/634 would be a good example starting point. His code adds a new arrowhead, which includes a filled
version.
I will go through the PR to understand the work well. Then start the work on this issue. Might take me a day to understand the PR well. I will start work from tomorrow.
@gavin-ts can you knock this out?
I already tried shape: triangle
style.filled: false
but that didn't work for target arrowhead
Trying the v.0.6.2 release and it doesn't seem to work:
A1 -> A2: {
target-arrowhead.shape: triangle
style.filled: false
}
B1 -> B2: {
target-arrowhead.shape: arrow
style.filled: false
}
C1 -> C2: {
target-arrowhead.shape: circle
style.filled: true
}
@hinogi @PackRuble
The style pertains to the arrowhead, not the connection.
A1 -> A2: {
target-arrowhead.shape: triangle
target-arrowhead.style.filled: false
}
C1 -> C2: {
target-arrowhead.shape: circle
target-arrowhead.style.filled: true
}
@alixander Thank you very much, I apologize for the inattention. Using target-arrowhead.style.filled
helped)
we have it for diamond and circle, but triangle unfilled has meaning in uml too
https://d2lang.com/tour/connections/#arrowheads