search

terrastruct / d2

D2 is a modern diagram scripting language that turns text to diagrams.
https://d2lang.com
Mozilla Public License 2.0
16.18k stars 401 forks source link

Combining circle shape for arrowheads with sketch mode removes all arrowheads #1937

Open ddolan-lutron opened 1 month ago

ddolan-lutron commented 1 month ago

See this playground.

Setting the arrowhead shape for either source or target arrowheads to circle causes all arrowheads to be omitted from the diagram when Sketch Mode is used. Seems to be independent of other arrowhead properties.

sossost commented 1 month ago

Hi! @alixander I am sossost, a new contributor. I would like to solve this issue. Could you assign it for me?

alixander commented 1 month ago

Much appreciated @sossost !

See relevant starting tip here: https://github.com/terrastruct/d2/issues/1936#issuecomment-2103037590

sossost commented 1 month ago

@alixander hello. I tried this issue because it seemed interesting, but it was too difficult due to my lack of understanding of the Go language. Can I give someone else a chance?? sorry.

alixander commented 1 month ago

No worries @sossost , thanks for trying!

bo-ku-ra commented 1 month ago

maybe i'm looking in the wrong place, but...

sketch.go (func ArrowheadJS) case d2target.CircleArrowhead: and case d2target.FilledCircleArrowhead: are missing?

danielsuh05 commented 1 month ago

I'd like to take this issue if possible, I feel pretty comfortable in the D2 repo now.