Improve APCA implementation

drwpow commented 5 months ago

Changes

🤔 There’s something still screwy with the APCA numbers I’m getting from apca-w3 vs the Contrast Checker Tool. There do seem to be multiple different versions of the APCA formula floating around the interwebz, npm, and Myndex’ GitHub. Hopefully I can get a review soon of this implementation (requested)!

Right now I’m chalking up a slight variance of numbers to the apca-w3 package possibly being newer? than some of the online tools. But perhaps there’s still a bug in my code somewhere. IDK, but either way I’m seeing better numbers here with the fixes.

How to Review

Tests updated; tests should pass

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 4c45c6a9e93e545d8c9d3dc8a43c4e1fd581c46c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | -------------------- | ----- | | @cobalt-ui/lint-a11y | Patch | | @cobalt-ui/core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cloudflare-pages[bot] commented 5 months ago

Deploying cobalt-ui with Cloudflare Pages

Latest commit:	`4c45c6a`
Status:	✅ Deploy successful!
Preview URL:	https://eaee400e.cobalt-ui.pages.dev
Branch Preview URL:	https://improve-apca.cobalt-ui.pages.dev

View logs

terrazzoapp / terrazzo