Fix: code quality issues

terrencepreilly / darglint

A python documentation linter which checks that the docstring description matches the definition.

MIT License

481 stars 41 forks source link

Fix: code quality issues #154

Closed withshubh closed 3 years ago

withshubh commented 3 years ago

Description

Hi :wave: I ran the DeepSource static analyzer on the forked copy of this repo and found some interesting code quality issues affecting this repo. This PR fixes a few of them.

Summary of changes

Removed length check in favour of truthiness of the object
Removed unnecessary use of comprehension
Removed unnecessary comprehension
Merged isinstance calls
Removed unused imports
Added .deepsource.toml file for DeepSource integration

terrencepreilly commented 3 years ago

I appreciate the suggestions. But I'd rather not add configurations for third-party services if I can help it, and there are too many changes in a single PR for me to review in a reasonable amount of time.