terrestris / shogun-legacy

⛔️ DEPRECATED, please use https://github.com/terrestris/shogun-core
Other
16 stars 16 forks source link

Merge the refactoring-branch into master #44

Closed marcjansen closed 10 years ago

marcjansen commented 10 years ago

(This is a replacement for #43)

I think we should merge the refactoring-branch into master.

Changes in this branch (which is the cleaned up counterpart of the original refactoring-branch):

Please review.

buehner commented 10 years ago

Hi Marc,

thanks for this large PR. I reviewed the commits and in principle everything looks fine, but it seems that https://github.com/marcjansen/shogun/commit/9f3833683b4ea4551fb82e37a079788a41daa83c is part of a project-specific solution. So I would suggest to remove that commit from the PR as it is not really needed in SHOGun.

Regards, Nils

marcjansen commented 10 years ago

Thanks for the review @buehner. I removed the offending commit.