Closed marcjansen closed 10 years ago
Hi Marc,
thanks for this large PR. I reviewed the commits and in principle everything looks fine, but it seems that https://github.com/marcjansen/shogun/commit/9f3833683b4ea4551fb82e37a079788a41daa83c is part of a project-specific solution. So I would suggest to remove that commit from the PR as it is not really needed in SHOGun.
Regards, Nils
Thanks for the review @buehner. I removed the offending commit.
(This is a replacement for #43)
I think we should merge the
refactoring
-branch into master.Changes in this branch (which is the cleaned up counterpart of the original refactoring-branch):
commons-lang3
(mostly used for the model methodstoString
,hashCode
&equals
)DatabaseDAO
getDataByFilter
fields
andignoreFields
setEagerFetchModeForCollections
)initializeDeep
to avoidfailed to lazily initialize - no session or session was closed
hasUserRoleByUsernameAndRolename
NotLike
fields
andignoreFields
hashCode()
(subclasses override this)equals(Object obj)
(subclasses override this)toString
(subclasses override this)info()
FetchType.LAZY
SUBSELECT
)Group
roles
deletable
MapConfig
resolutions
scales
MapLayer
owner
additionalOwners
users
Role
User
Group
)user_firstname
user_lastname
user_title
user_bureau
user_department
user_unit
user_description
modules
mapLayers
mapConfigs
roles
user_module_list
getRoles
hasRole
authentication-provider
changed to match new model structure (see above)LeanBaseModelListSerializer
LeanBaseModelSetSerializer
TODO
sPlease review.