search

terriann / Simply-Pinterest-WordPress-Plugin

Simply Pinterest is a WordPress Pinterest sharing plugin. Perfect for DIY, craft, lifestyle & photography blogs to promote your content easily with just the right bells & whistles
http://simplypinterest.com
GNU General Public License v2.0
0 stars 2 forks source link

Post title is taken instead of alt attribute #25

Open Helmi opened 9 years ago

Helmi commented 9 years ago

For whatever reasons this worked before but doesn't work now for a while (since the last update?).

So far the Pinterest button was always generated using the alt-text from the image as a description. Now (even though an alt tag is present and filled) the description carries the post title.

I'm not a coder but for what i could find in the scripts (especially the script.js) it should use the alt title.

Any idea how this may come?

Thanks

terriann commented 9 years ago

Hi @Helmi I was just informed by one of my early testers that she encountered a bug that when she did a Genesis update it reset all her settings. I see where the bug is in the plugin code and will be patching that just as soon as possible. I'm guessing that may be what happened to you. Can you check your settings page and let me know if your settings were reset as well and if so what update did you run (was it a WordPress update?)

Thanks so much for the feedback, I appreciate that you took the time to file a bug report :)

terriann commented 9 years ago

For my own reference when I fix the bug here's the developer handbook page I'll need to reference https://developer.wordpress.org/plugins/the-basics/uninstall-methods/

Helmi commented 9 years ago

Hey @terriann - definitely not a Genesis issue here and my settings look good on the settings page. I also don't see any setting where i can set what is used as a title at pinterest - did i miss something?

terriann commented 9 years ago

Hmmmmm @Helmi - can you provide a URL to your blog so I can take a look at the affected page to try and debug? If you don't want to share your URL publicly you can email it to me at terri@terriswallow.com

BTW you're totally right there is no setting for using the post title, I was confused and thinking about a different project on that thought. <--needs round 2 of the coffee today!

Helmi commented 9 years ago

@terriann not a problem at all - my wife's blog is at http://stempelwiese.de and you may find pinterested images in nearly every blog post. Whenever you post them to pinterest with the button it doesn't take the value from the alt-attribute of the image but the posts title instead (already visible in the link)

terriann commented 9 years ago

To be honest: I'm a bit puzzled by this bug! I can see the alt tag being used to generate the Pinterest reference for building the button but somewhere between when that's written to the page and once Pinterest's pinit.js file is done widgetizing the button the title tag for the page gets swapped out. I'm going to try and reproduce it on my test instances but I'm wondering if there is a conflict with another plugin. Do you have many other plugins installed and activated?

Helmi commented 9 years ago

Hmm actually not too much but sure quite some. I'll try to look through if i can find some possible suspects. The strange thing is my wife said it worked until the last update - but sure enough there have also been one or two plugins installed that could also be the issue.

Maybe i'll just kill all the other plugins for a moment and see what changes.

terriann commented 9 years ago

What update was it that she/you ran? Was it a WordPress update? I actually haven't pushed an update to the plugin in quite some time so I don't think it was an update for the plugin. I'd like to try and reproduce it so that's helpful for me to debug

Helmi commented 9 years ago

Looks like i got it. It seems to have to do with W3TC and i think it's either Minification or the browser caching that causes it. I have a hard time getting closer to the problem but it's definitely away as soon as i completely disable W3TC.

terriann commented 9 years ago

Excellent! Thanks for your help looking into it Helmi. I can try and slot some time to look into this bug in a test instance and try and put together a fix for it! Guess I have 2 bugs to fix this weekend :+1:

terriann commented 9 years ago

To be 100% clear the W3TC you are referring to is this plugin: https://wordpress.org/plugins/w3-total-cache/

Helmi commented 9 years ago

Yes it's exactly this (rather famous) caching plugins.

And i think i've narrowed the problem down to what it actually is. In the Browser Cache settings of this plugin (which basically control the cache headers and TTL for static file request and some other stuff) there's a setting which is called:

"Prevent caching of objects after settings change"

By ticking this function on (which we had due to a proxy server we are using) every static files get's embedded with a random string attached as parameter (like http://domain.com/script/script.js?234ouhjkn) - this enables the plugin to change URLs after setting change and to automatically invalidate these URLs for the browsers cache - effectively the URL doesn't change but the browser sees a different URL and doesn't fetch the file from it's local cache.

This setting reproducably causes the problem we had. I have it switched off now and you can see the plugin works as intended. I can't really tell what causes this bug but maybe you have an idea?

Anyway - thanks for having a look into that. Let me know if you find something.