terricain / aioboto3

Wrapper to use boto3 resources with the aiobotocore async backend

Apache License 2.0

732 stars 75 forks source link

[noref] Pass ExtraArgs when calling getobj during download_fileobj #211

Closed u-ashish closed 4 years ago

u-ashish commented 4 years ago

Changelog

During download_file and download_fileobj, the aioboto3 client allows users to pass ExtraArgs. In its implementation (patched by get_object), it doesn't pass those args through, so when trying to use this to download from a RequestPayer bucket, it currently fails.

Just updated the step to pass it through...

u-ashish commented 4 years ago

@terrycain Let me know if I should do anything differently or draft the PR in a different manner... tried to file a style guide but maybe I'm blind, didn't see anything.

Thanks for taking a look!

terricain commented 4 years ago

Hey, good spot thanks :) Yeah stylewise theres not really a guide, some of the code is pure monkey patching boto3 so I tried to keep the code as similar as possible, but then for the parts I've implemented myself as long as it looks sane I'm happy.

terricain commented 4 years ago

v8.0.4 is out :smile: