search

terricain / aioboto3

Wrapper to use boto3 resources with the aiobotocore async backend
Apache License 2.0
719 stars 74 forks source link

bump aiobotocore to 2.1.0 and aioboto3 to 9.3.1 versions #252

Closed abivolmv closed 2 years ago

abivolmv commented 2 years ago

bump aiobotocore to 2.1.0 and aioboto3 to 9.3.1 versions

abivolmv commented 2 years ago

@terrycain how would I run tests against buckets ? Is there a way to configure AWS Profile that should be used for tests ? I saw that in the tests it is generating bucket names based on uuid - so I suppose it is creating the bucket then deleting it ? Or the workkflow CI tests would do it ?

terricain commented 2 years ago

Hey, so the tests spawn a mock s3 server (from the moto project) and uses that

terricain commented 2 years ago

FYI the pyproject.toml version is ignored as the poetry-dynamic-versioning mentioned in the build_system section gets the version from a tag

terricain commented 2 years ago

Tests look good :) thanks for this.

terricain commented 2 years ago

v9.3.1 is on pypi :)

abivolmv commented 2 years ago

Ah ok, that's why it took a lot of time - I thought it's trying to create real buckets in aws.

terricain commented 2 years ago

Nah it spins up a test server locally and uses that. It used to make buckets on aws but every now and again I'd debug tests and then kill them mid run and my aws account was being filled with random buckets