terricain / aioboto3

Wrapper to use boto3 resources with the aiobotocore async backend
Apache License 2.0
743 stars 76 forks source link

Bumped aiobotocore to 2.5.1 #306

Closed szymon-planeta closed 1 year ago

szymon-planeta commented 1 year ago

bump to aiobotocore 2.5.1

szymon-planeta commented 1 year ago

@terrycain I have reviewed what causes the test to fail - aiobotocore update bumps boto3 from 1.26.76 to 1.26.161 which updates upload_file function code (from this to this)

Diff:

9,10c9,10
<         s3 = boto3.resource('s3')
<         s3.meta.client.upload_file('/tmp/hello.txt', 'mybucket', 'hello.txt')
---
>         s3 = boto3.client('s3')
>         s3.upload_file('/tmp/hello.txt', 'mybucket', 'hello.txt')
12,13c12,13
<     Similar behavior as S3Transfer's upload_file() method,
<     except that parameters are capitalized. Detailed examples can be found at
---
>     Similar behavior as S3Transfer's upload_file() method, except that
>     argument names are capitalized. Detailed examples can be found at

Since this changes only docstring I've assumed that it's safe to add new digest

szymon-planeta commented 1 year ago

@terrycain could you please take a look at this when you have a chance? Would really like to use FaceOccluded which was added to Rekognition recently

szymon-planeta commented 1 year ago

@terrycain sorry for another bump, thought you might've missed it

WilkenSteiner commented 1 year ago

Hey @terrycain! It would be great to merge this, we need a patch that is included in a dependency of the more recent aiobotocore.

Hey @szymon-planeta ! May I add a commit bumping this directly to 2.5.4? I lock to boto3 = ["boto3 (>=1.28.17,<1.28.18)"], and your comment still applies (and the hash you added doesn't change).

szymon-planeta commented 1 year ago

@WilkenSteiner sure

terricain commented 1 year ago

Sorry for the absence guys. I'll be bumping to aiobotocore 2.6.0 today 😄 (i'll close this PR as it'll be superseded by my changes)

terricain commented 1 year ago

v11.3.0 is out supporting aiobotocore 2.6.0