Closed huonw closed 10 months ago
This currently fails due to test_patches.py
:
Boto3 version: 1.33.1 aiobotocore version: 2.8.0
Digest of copy:7f9edd96f418e09c00d26538a7382b217e0843e5 not found in: {'c4423d0a6d3352553befdf0387987c09812fcaff', 'e8154a4de3b97dd2ab29d250c005b03e8fc7ed71'}
It looks like the most recent change to https://github.com/boto/boto3/pull/3946 is https://github.com/boto/boto3/blob/develop/boto3/s3/inject.py#L371-L450.
I think no change is required to the code, just blessing the 7f9edd96f418e09c00d26538a7382b217e0843e5
hash, because aioboto3 doesn't use https://github.com/boto/s3transfer and the CRTTransferManager
there that's missing the .copy
method.
Breadcrumbs:
preferred_transfer_client
property is only read by _should_use_crt
_should_use_crt
is only used by create_transfer_manager
aioboto3
doesn't call eitherHeya @terrycain, thanks for this library! Do you have thoughts on this PR? (A gentle ping in case you missed it! 😄 )
Nice, sorry for the delay, go ahead and update test_patches.py and we'll get this merged.
I just opened a PR to @huonw with the test fix, and a PR straight into @terrycain's main to try helping expediting all of this. Thanks to both of you guys for the contributions to the entire community! https://github.com/terrycain/aioboto3/pull/322
v12.1.0 is out
Thank you! And thanks @fritzpaz for saving me some effort 👍
https://github.com/aio-libs/aiobotocore/releases/tag/2.8.0
This in particular allows using botocore>=1.32.1, which comes with a massive decrease in installed size: 83MB -> 20MB (see https://github.com/boto/botocore/issues/2365#issuecomment-1813447304 and/or https://github.com/aio-libs/aiobotocore/issues/1056 for more details).
Thanks for aioboto3!