search

terricain / aioboto3

Wrapper to use boto3 resources with the aiobotocore async backend
Apache License 2.0
698 stars 73 forks source link

Implement multipart file downloads. Closes #131 and #264 #332

Closed kyboi closed 1 month ago

kyboi commented 2 months ago

Implement multipart file downloads. Tests still run fine (at least locally), both with aiofiles and normal sync files.

kyboi commented 2 months ago

@terrycain It looks like workflows to run the tests need your approval

terricain commented 1 month ago

I'll have a look at this today. Whilst i'm not against importing aiofiles, this assumes the file like object passed in to download_fileobject is a seekable stream, which would not be the case if its a network socket.

terricain commented 1 month ago

This got merged and is part of v13.0.0.

See: https://github.com/terricain/aioboto3/commit/34fec529a286dc77efc55d7c977b2e2e0f6cac2f and https://github.com/terricain/aioboto3/commit/f5fd9fedec5c88fc9897f06218476f88ed928d8b