Closed plotlogic-andrew closed 1 month ago
Yeah I've not looked at the S3 transfer code in years but im sure it should not multipart if the file is small enough. Will look at fixing it at some point
I'd call it a feature request more than a bug :-).
I'm happy to contribute - but after a quick look the code for upload_fileobj coming from botocore seemed opaque at best to me. I'll look again when I have more time to.
And thanks for putting this together! I've always been bothered that boto3 defaults to 10 threads to keep an upload pipe full.
s3.upload_fileobj
now respects Config.multipart_threshold
and will issue a singular s3.put_object
if the file is below the threshold.
Description
upload_fileobj
always does multipart uploads. This results in:boto3.upload_fileobj
was usedWhat I Did
The
uploadfile_obj
code make reference tomultipart_chunksize
but doesn't use it.