search

terricain / certbot-dns-azure

AzureDNS Certbot plugin
Other
33 stars 16 forks source link

Added support for alternative Azure Clouds #11

Closed jhisc closed 2 years ago

jhisc commented 2 years ago

Resource updated to pass base url when calling the Azure Python SDK. This adds support for the alternative azure clouds and defaults to Azure Public cloud.

I have tested this against GovCloud using:

export AZURE_ENVIRONMENT=azureusgovernmentcloud
certbot certonly --dns-azure-config ~/azure.ini -d example.domain.com
jhisc commented 2 years ago

@terrycain @rnakamine @moriyoshi Please let me know if you need anything else from me on this :)

terricain commented 2 years ago

Look good. Would you mind also making it so that the azure cloud could also be specified from the config file? And finally mind updating the docs to mention the env var (and config option:smile: ) here https://github.com/binkhq/certbot-dns-azure/blob/master/certbot_dns_azure/__init__.py

jhisc commented 2 years ago

Thanks @terrycain. Updated 😀

terricain commented 2 years ago

Other than that minor if change, all looks good. I'll run these through my own azure environment tomorrow just for my own sanity then I'll merge it. :smile:

jhisc commented 2 years ago

Thank you!

llanse01 commented 2 years ago

@terrycain is there a timeline on the merge. I would like to make use of these changes

terricain commented 2 years ago

1.4.0 should be out :)