terricain / certbot-dns-azure

AzureDNS Certbot plugin
Other
33 stars 16 forks source link

Connecting plugin via snap now causes certbot to crash #23

Closed RedChops closed 1 year ago

RedChops commented 1 year ago

I've been using this plugin for quite some time now, and as of some recent update having it connected causes certbot to crash with the following error message:

An unexpected error occurred:
pkg_resources.ContextualVersionConflict: (cryptography 38.0.1 (/snap/certbot/2414/lib/python3.8/site-packages), Requirement.parse('cryptography<38,>=0.6'), {'msal'})
Ask for help or search for solutions at https://community.letsencrypt.org. See the logfile /tmp/certbot-log-_bnwfto2/log or re-run Certbot with -v for more details.

I confirmed that this is being caused via this plugin, since removing it allows certbot to run again.

RedChops commented 1 year ago

It looks like the snap container just needs to be rebuild most likely. Certbot now uses cryptography 38, and the snap package for this plugin looks like it just has an old version of an azure library bundled in

m4rkglenn commented 1 year ago

Is there a workaround for this, i am having the same issue

cpressland commented 1 year ago

Unfortunately @terrycain is somewhat indisposed right now and I don’t have access to the Snap Store to patch this. I have asked him for this but it’ll happen later this week.

For the moment, downgrading certbot is one solution, not great, not terrible.

cerebrate commented 1 year ago

I ran into this issue myself and build a hacked version of certbot-dns-azure to fix it. I've submitted my changes in PR #24; if you need it in a hurry, like I did, you can grab those and build from there.

(Or, if you trust me, you can always grab my build here

certbot-dns-azure_1.5.0_amd64.snap.gz

and install it with sudo snap install --dangerous certbot-dns-azure_1.5.0_amd64.snap until the new official version is ready.)

m4rkglenn commented 1 year ago

Thanks @cerebrate, working perfectly now. :)

jaldinger commented 1 year ago

For those preferring to downgrade, here are the commands I used to show available versions and revert to the previous (1.30.0), which fixed the issue: snap list certbot --all snap revert certbot

sirsnork commented 1 year ago

Any news here? I can't seem to get cerebrate's version it show under 'certbot plugins' at all obviously the old version is broken. Downgrading doesn't seem to be an option either as it only lists 1.31.0 on my installs

cerebrate commented 1 year ago

@sirsnork Just to check, is it showing up under snap connections?

Interface           Plug            Slot                       Notes
content[certbot-1]  certbot:plugin  certbot-dns-azure:certbot  manual

If not, you may need to connect it manually for it to show up.

sirsnork commented 1 year ago

@cerebrate No, nothing is returned from that command.

certbot plugins shows the 4 base plugins only. It is "installed" under /snap, ie the files are there in a folder called certbot-dns-azure, uninstalling removes it ok and running the install commands creates that folder again (so it's not the old plugin version that's there)

cerebrate commented 1 year ago

snap connect certbot:plugin certbot-dns-azure:certbot should be what you need, then.

sirsnork commented 1 year ago

@cerebrate Legend! All good now!

terricain commented 1 year ago

Sorry lads, was in the middle of moving house. I've promoted 2.0.1 to latest/edge, can someone give that a test for me?

m4rkglenn commented 1 year ago

Thanks Terry!

I have tested this and is now working as expected.

Kind Regards, Mark Mark Glenn Cloud Operations Engineer Kofax Northern Ireland Limited - Derry

Mark Glenn Cloud Operations Engineer

[cid:Kofax_ab6d7362-d88f-454c-a5e0-9fbdacd27b9c.jpg]

Kofax Northern Ireland Limited 113-118 Duncreggan Road DERRY, County Derry BT48 0AA

Tel: +44 28 7127 2659 Mobile: +44 7920 410 917 @.***

[cid:WorkLikeTomorrow_5b748fe4-9e86-42f8-b5af-b79a2d6ee254.jpg]

Company number: NI031519, Northern Ireland Registered office: 113-118 Duncreggan Road, Derry, BT48 0AA


This communication is only for the use of the intended recipient. It may contain confidential or proprietary information. If you are not the intended recipient or have received this communication in error, please notify the sender via phone and destroy this communication immediately.

From: Terry Cain @.> Sent: Wednesday, November 9, 2022 6:45 PM To: terrycain/certbot-dns-azure @.> Cc: Mark Glenn @.>; Comment @.> Subject: [EXTERNAL] Re: [terrycain/certbot-dns-azure] Connecting plugin via snap now causes certbot to crash (Issue #23)

Sorry lads, was in the middle of moving house. I've promoted 2.0.1 to latest/edge, can someone give that a test for me?

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fterrycain%2Fcertbot-dns-azure%2Fissues%2F23%23issuecomment-1309208235&data=05%7C01%7C%7C43b1f856fd2047bd368d08dac2828d0d%7Cbcd8ba5f75e24d6c8aa5fff6c8baa1ff%7C0%7C0%7C638036163221808986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jobPo6Wg59Jf40j1vaHFqT1TjFHKy26z3LdDtise7ZI%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYHL25GWPDAYVMOXQNPBUFLWHPWL7ANCNFSM6AAAAAARAQC42M&data=05%7C01%7C%7C43b1f856fd2047bd368d08dac2828d0d%7Cbcd8ba5f75e24d6c8aa5fff6c8baa1ff%7C0%7C0%7C638036163221808986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=q%2FfF9G5kWeKBu5nUr%2BaPSWOeCHAXw%2FMtU07zqHCB0cs%3D&reserved=0. You are receiving this because you commented.Message ID: @.**@.>>

terricain commented 1 year ago

Great thanks :) I'll promote it to the latest/stable branch on the weekend if I get no issues with it until then