search

terricain / certbot-dns-azure

AzureDNS Certbot plugin
Other
33 stars 16 forks source link

Dependency on azure-core>=1.25.0 #40

Closed osirisinferi closed 10 months ago

osirisinferi commented 11 months ago

In https://github.com/terrycain/certbot-dns-azure/commit/0b158bb4430f60ec724e726484f5f2fd6ab84486 the usage of azure.core.utils.CaseInsensitiveDict was added.

However, this implementation wasn't added until azure-core-1.25.0.

Currently, certbot-dns-azure only depends on azure-identity>=1.11.0 and azure-mgmt-dns>=8.0.0. Currently, azure-mgmnt-dns doesn't depend on azure-core entirely and azure-identity depends on azure-core<2.0.0,>=1.11.0, so that's not enough either.

Perhaps it's wise to add a dependency on azure-core>=1.25.0?

terricain commented 11 months ago

Oh, yeah definitely, great spot!

terricain commented 10 months ago

Released 2.4.0 to PyPI and a snap to the edge channel, will promote the snap to stable in a week.