terricain / certbot-dns-azure

AzureDNS Certbot plugin
Other
33 stars 16 forks source link

Add DefaultAzureCredential as fallback in case of no auth config #8

Closed figglewatts closed 1 year ago

figglewatts commented 3 years ago

This PR adds DefaultAzureCredential as a fallback in case no authentication method is configured in the INI file.

To implement this, I have:

Looking forward to seeing what you think :)

terricain commented 3 years ago

Hey, this looks good, definitely should have used DefaultAzureCredential when they updated the DNS library.

The only issue I could see with this would be if lets say the VM had 2 user assigned identities, would it still work? Could you test that scenario. If its all good, happy to merge.

terricain commented 1 year ago

If you feel this is still relevant and can test that scenario I mentioned feel free to re-open this