search

terricain / sanic-json-logging

JSON Logging for Sanic
Apache License 2.0
10 stars 4 forks source link

fix formatter when exception is missing #137

Closed digitalkaoz closed 3 years ago

digitalkaoz commented 3 years ago

sorry, it seems we missed a case, tested it again in a real world application

digitalkaoz commented 3 years ago

@terrycain willing to merge this too? I also added more test cases

terricain commented 3 years ago

Yeah, sorry been busy, will look over it tomorrow :smile:

terricain commented 3 years ago

Nice looks good

digitalkaoz commented 3 years ago

thanks man, working like a charm now! Finally usable Cloudwatch Logs (they have automatic parsing for JSON logs)

terricain commented 3 years ago

Yup, CWLogs is pretty nice

On Thu, Sep 2, 2021 at 9:36 AM Robert Schönthal @.***> wrote:

thanks man, working like a charm now! Finally usable Cloudwatch Logs (they have automatic parsing for JSON logs)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/terrycain/sanic-json-logging/pull/137#issuecomment-911389762, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPE6XLQRM2GPG4I3HD2WADT74ZPPANCNFSM5DB3NB2A .