terrier-org / pyterrier

A Python framework for performing information retrieval experiments, building on http://terrier.org/
https://pyterrier.readthedocs.io/
Mozilla Public License 2.0
397 stars 63 forks source link

Fix typo in Learning to Rank Examples.ipynb #432

Closed Tlamatinime closed 3 months ago

Tlamatinime commented 3 months ago

Changes pt.piptlines.LTR_pipeline to pt.pipelines.LTR_pipeline

cmacdonald commented 3 months ago

Hi @Tlamatinime, thanks for the PR. I've reviewed the underlying notebook, and seen that it needs rewriting to address various changes in the LTR api. e.g. the correct call is pt.ltr.apply_learned_model().

I'm going to close this, but address your feedback in the fat branch (see https://github.com/terrier-org/pyterrier/compare/master...fat).

Thanks once again for highlighting the need for this notebook to be improved.