search

terror / mcgill.courses

A course search and review platform for McGill University
https://mcgill.courses
Creative Commons Zero v1.0 Universal
32 stars 8 forks source link

Persist explore filter state until page refresh #517

Closed 39bytes closed 5 months ago

39bytes commented 5 months ago

Resolves #510

SamZhang02 commented 5 months ago

so fast

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.16%. Comparing base (1ce7056) to head (7d51ae1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #517 +/- ## =========================================== + Coverage 0 88.16% +88.16% =========================================== Files 0 43 +43 Lines 0 6124 +6124 =========================================== + Hits 0 5399 +5399 - Misses 0 725 +725 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

terror commented 5 months ago

What do we think about persisting to local storage?

39bytes commented 5 months ago

What do we think about persisting to local storage?

Would be annoying/confusing for users when you come back after a while, the point is just so you can navigate from explore and back without losing it