terrychou / iVim

A vim port to iOS.
598 stars 34 forks source link

iplug quit when cloning #127

Closed suliveevil closed 4 years ago

suliveevil commented 4 years ago

✅ 45 plugin install with option -q test ❌ 45 plugins install without option test


iplug add https://github.com/majutsushi/tagbar https://github.com/preservim/nerdtree https://github.com/SirVer/ultisnips https://github.com/itchyny/lightline.vim https://github.com/preservim/nerdcommenter https://github.com/ryanoasis/vim-devicons https://github.com/Yggdroot/indentLine https://github.com/jiangmiao/auto-pairs https://github.com/lervag/vimtex https://github.com/justinmk/vim-sneak https://github.com/tpope/vim-repeat https://github.com/ludovicchabant/vim-gutentags https://github.com/prabirshrestha/vim-lsp https://github.com/kana/vim-textobj-user https://github.com/honza/vim-snippets https://github.com/liuchengxu/vim-which-key https://github.com/justinmk/vim-dirvish https://github.com/wakatime/vim-wakatime https://github.com/mg979/vim-visual-multi https://github.com/liuchengxu/vista.vim https://github.com/liuchengxu/eleline.vim https://github.com/mhinz/vim-signify https://github.com/dense-analysis/ale https://github.com/Shougo/deoplete.nvim https://github.com/easymotion/vim-easymotion https://github.com/vimwiki/vimwiki https://github.com/junegunn/goyo.vim https://github.com/itchyny/calendar.vim https://github.com/Yggdroot/LeaderF https://github.com/rafi/awesome-vim-colorschemes https://github.com/skywind3000/asyncrun.vim https://github.com/ncm2/ncm2 https://github.com/Shougo/defx.nvim https://github.com/prabirshrestha/asyncomplete.vim https://github.com/andymass/vim-matchup https://github.com/vim-syntastic/syntastic https://github.com/tpope/vim-commentary https://github.com/python-mode/python-mode https://github.com/kana/vim-textobj-fold https://github.com/jceb/vim-orgmode https://github.com/idanarye/vim-vebugger https://github.com/sbdchd/neoformat https://github.com/mhinz/vim-startify https://github.com/tpope/vim-surround https://github.com/ctrlpvim/ctrlp.vim

Quit when cloning,and iplug list say that I have 0 plugin installed. But I can see 28 folders in ~/.vim/pack/ivim/start Test :Goyo and the interface shows that plugin Goyo works. Wired.

suliveevil commented 4 years ago

run cmd again and then I got this already exists、disabled

htkm commented 4 years ago

Thanks for having a battle test! I don't know much about how iOS works, my guess is that each app installed in iOS is sandboxed thus subject to unexpected result or even app termination when iOS thinks it's necessary to keep other apps working as designed.

But you are right, would you mind test with 30, 20, 10, and 5 plugins and comeback with the result? That might give a better coordination to someone trying to take this issue to a pull request.

suliveevil commented 4 years ago

Yeah, I can do this.Wait a minute.

suliveevil commented 4 years ago

❌ 29 plugins test Quit when installing (maybe it’s occurred due to switching to other app?) 24 folders found,0 plugins on iplug list


iplug add https://github.com/kana/vim-textobj-user https://github.com/honza/vim-snippets https://github.com/liuchengxu/vim-which-key https://github.com/wakatime/vim-wakatime https://github.com/mg979/vim-visual-multi https://github.com/liuchengxu/vista.vim https://github.com/liuchengxu/eleline.vim https://github.com/mhinz/vim-signify https://github.com/dense-analysis/ale https://github.com/Shougo/deoplete.nvim https://github.com/easymotion/vim-easymotion https://github.com/vimwiki/vimwiki https://github.com/junegunn/goyo.vim https://github.com/itchyny/calendar.vim https://github.com/rafi/awesome-vim-colorschemes https://github.com/skywind3000/asyncrun.vim https://github.com/ncm2/ncm2 https://github.com/Shougo/defx.nvim https://github.com/prabirshrestha/asyncomplete.vim https://github.com/andymass/vim-matchup https://github.com/tpope/vim-commentary https://github.com/python-mode/python-mode https://github.com/kana/vim-textobj-fold https://github.com/jceb/vim-orgmode https://github.com/idanarye/vim-vebugger https://github.com/sbdchd/neoformat https://github.com/mhinz/vim-startify https://github.com/tpope/vim-surround https://github.com/ctrlpvim/ctrlp.vim
suliveevil commented 4 years ago

29 plugin test

suliveevil commented 4 years ago

BTW: I use this Shortcuts to test.

suliveevil commented 4 years ago

❌ 25 plugins test installed 21,3 faild due to http error,1 missing iplug list couldn’t correctly show them. 25 plugins test

suliveevil commented 4 years ago

✅ 20 plugin test


iplug add https://github.com/liuchengxu/vim-which-key https://github.com/liuchengxu/vista.vim https://github.com/liuchengxu/eleline.vim https://github.com/mhinz/vim-signify https://github.com/easymotion/vim-easymotion https://github.com/junegunn/goyo.vim https://github.com/itchyny/calendar.vim https://github.com/rafi/awesome-vim-colorschemes https://github.com/Shougo/defx.nvim https://github.com/prabirshrestha/asyncomplete.vim https://github.com/andymass/vim-matchup https://github.com/tpope/vim-commentary https://github.com/python-mode/python-mode https://github.com/kana/vim-textobj-fold https://github.com/jceb/vim-orgmode https://github.com/idanarye/vim-vebugger https://github.com/sbdchd/neoformat https://github.com/mhinz/vim-startify https://github.com/tpope/vim-surround https://github.com/ctrlpvim/ctrlp.vim

20 plugin test

suliveevil commented 4 years ago

✅ 10 plugins test

iplug add https://github.com/majutsushi/tagbar https://github.com/Yggdroot/indentLine https://github.com/liuchengxu/vista.vim https://github.com/liuchengxu/eleline.vim https://github.com/junegunn/goyo.vim https://github.com/itchyny/calendar.vim https://github.com/Shougo/defx.nvim https://github.com/prabirshrestha/asyncomplete.vim https://github.com/python-mode/python-mode https://github.com/ctrlpvim/ctrlp.vim 
suliveevil commented 4 years ago

20 or 10 is just ok for iplug to deal with, I won’t test 5 again.

terrychou commented 4 years ago

Thanks for this pressure test, it is very helpful. By "quit", do you mean "iVim crashes"? Also, right now, iplug doesn't implement background tasks, so it wouldn't work if you switch away from iVim while iplug is working.

iplug summarizes and records installed plugins at the end of whole operation, so if the adding fails, there would be zero plugins recorded.

htkm commented 4 years ago

BTW: I use this Shortcuts to test.

I was amazed by reading your shortcut which made me feel your overwhelming energy towards iVim. Inspired by you, I came up with an idea that might be able to support you hence the community. Let me allow a few hours. Thanks guys I was boring Saturday but no more.

suliveevil commented 4 years ago

Yes, too many plugins installing simutanously makes iVim crash.

By "quit", do you mean "iVim crashes"?

suliveevil commented 4 years ago

I made this Shortcuts using Dictionary Action Builder

terrychou commented 4 years ago

@suliveevil would you try the "45" one with the option -q? It won't show the progress view but will give a short notification at the end of the whole operation. If this succeeds, it would be something wrong with the progress view...

suliveevil commented 4 years ago

@htkm I made Vim assistant by using this Dictionary Action Builder Shortcuts.

Vim assistant

suliveevil commented 4 years ago

Yeah,wait a minute.

@suliveevil would you try the "45" one with the option -q? It won't show the progress view but will give a short notification at the end of the whole operation. If this succeeds, it would be something wrong with the progress view...

suliveevil commented 4 years ago

@suliveevil would you try the "45" one with the option -q? It won't show the progress view but will give a short notification at the end of the whole operation. If this succeeds, it would be something wrong with the progress view...

Install with option -q works great and didn't crash,only the unknown waiting and progressing bothered me. Update: 45 is too mmuch to use, it make iVim crash several times,and now I couldn't open iVim.

terrychou commented 4 years ago

I also tested the "45 bunch". Rather than crashing, it was that some plugins took longer because of the network condition. Which made the whole operation look not so fluent.

suliveevil commented 4 years ago

Yeah,Install with option -q is great, it would be better if there has a notification for each one plugin as a -n option or some othername.

But these 45 plugin crashes my iVim and I have to reinstall, which part I don’t understand.

terrychou commented 4 years ago

Actually, if adding with option -q or the progress view is dismissed by touching the Done button, there will be a notification shown after the whole operation. But it seems too short to stand out.

suliveevil commented 4 years ago

-q is great, and if there is a -n which means nontification for each one plugin insntalled will be better.

htkm commented 4 years ago

iplug iOS notification

This. You guys are making a fantastic progress. I am not sure if the GIF posted as well.

(added content) Glad the size of my animated GIF didn't cross the limit.

suliveevil commented 4 years ago

Notification is great!

htkm commented 4 years ago

@terrychou I realize something by seeing iOS notification brings the "seamless" or "continuity-like" user experience into the iVIM workflow. I don't think this is just a feature added to be able for casting a spell on @the-shortcut-wizard.

Seems to me like this has unlocked something enlightened and you probably noticed what that is 😃

terrychou commented 4 years ago

Another advantage of the system notifications is that they are also available as history for reference.

htkm commented 4 years ago

Great. Could you say a little more on history and reference?

terrychou commented 4 years ago

@htkm By that, I mean: https://github.com/terrychou/iVim/issues/133#issuecomment-636333854

htkm commented 4 years ago

Ah, okay thanks for the reference. Thinking about utilizing the system notification in iVim makes me think greedy.

terrychou commented 4 years ago

In version 2.22(2), I fixed a possible bug for this crash. Has the crash ever happened again?

suliveevil commented 4 years ago

Havn't test it, I'm a little tired of Install&Uninstall thing. Maybe I should just use Import&Export.