search

terrylinla / react-native-sketch-canvas

A React Native component for drawing by touching on both iOS and Android.
MIT License
696 stars 453 forks source link

add `promptForExternalWritePermissions` bool #101

Open toblerpwn opened 5 years ago

toblerpwn commented 5 years ago

Related to #100. This is not the best fix, as it does not fix item (2) in the issue noted, but at least it removes the permission prompt for (most?) consumers who don't need it.

A more proper fix, per #100, would prompt not based on a bool but actually based on some parameter specifying where one would like to save (and determining that the user doesn't have rights to it). Also, this prompt should appear only after save() (or similar) is invoked--not before.

anfriis commented 4 years ago

Works perfectly fine for my use case, thanks 🥇

AfanasievN commented 4 years ago

@terrylinla any progress on this one?

afincha commented 4 years ago

Would love to see this get in!

m4yer commented 3 years ago

I've tried to find any fork that fixed that issue but couldn't succeed so I created my own containing only this fix. I am too lazy to create npm package so if you want to use this you can just use the following:

npm i m4yer/react-native-sketch-canvas

Then use the component like this:

<SketchCanvas
    promptForExternalWritePermissions={false}
/>