terrylinla / react-native-sketch-canvas

A React Native component for drawing by touching on both iOS and Android.
MIT License
697 stars 453 forks source link

Android Build Issue #244

Open SolankiYogesh opened 8 months ago

SolankiYogesh commented 8 months ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @terrylinla/react-native-sketch-canvas@0.8.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@terrylinla/react-native-sketch-canvas/android/build.gradle b/node_modules/@terrylinla/react-native-sketch-canvas/android/build.gradle
index 31e44f2..8b192f5 100644
--- a/node_modules/@terrylinla/react-native-sketch-canvas/android/build.gradle
+++ b/node_modules/@terrylinla/react-native-sketch-canvas/android/build.gradle
@@ -28,5 +28,5 @@ android {
 }

 dependencies {
-    provided "com.facebook.react:react-native:+"
+    api "com.facebook.react:react-native:+"
 }

This issue body was partially generated by patch-package.

10wen commented 2 weeks ago

嗨!👋

首先,感谢您对这个项目的工作!🙂

今天我使用patch-package来修补@terrylinla/react-native-sketch-canvas@0.8.0我正在做的项目。

以下是解决我的问题的差异:

diff --git a/node_modules/@terrylinla/react-native-sketch-canvas/android/build.gradle b/node_modules/@terrylinla/react-native-sketch-canvas/android/build.gradle
index 31e44f2..8b192f5 100644
--- a/node_modules/@terrylinla/react-native-sketch-canvas/android/build.gradle
+++ b/node_modules/@terrylinla/react-native-sketch-canvas/android/build.gradle
@@ -28,5 +28,5 @@ android {
 }

 dependencies {
-    provided "com.facebook.react:react-native:+"
+    api "com.facebook.react:react-native:+"
 }

该问题主体部分由 patch-package 生成

That doesn't solve my problem: